CST 338 Week 4

 Review of Nettra’s Code

Overall feedback, code ran with no errors. Feedback for code is to add comments where the constructors and specific variables and what they do are, this is probably not needed, but the only thing I could see that could be changed. Great work!

Encapsulation

  • The instance variables are private. This matters because it ensures the variables are not accessed from an unknown class.
  • Getters and setters exist where appropriate in the code, such as, getRank and getSuit. Both are needed in order for the code to fully run and needed for follow-on parts of Project 1.

Constructors

  • The constructor validates its inputs in the code. If someone passes an invalid suit or value the code will throw an error.
  • There is no default constructor. No there doesn’t need to be one for Card or Deck since there are already defined constructors.

Readability and Style

  • The comments and the variable names and method names make it easy to follow the logic without running the code.
  • The code followed the Google Java Style Guide in terms of naming, braces, and spacing.



 Review of Sean’s Code

Overall feedback, code ran with no errors. Feedback for code is to go through the Google Java Style Guide. Most of it is there, but maybe because this was a cloned a pre-generated repository some of the spacings were off. Awesome work!

Encapsulation

  • The instance variables are private. This matters because it ensures the variables are not accessed from an unknown class.
  • Getters and setters exist where appropriate in the code, such as, getRank and getSuit. Both are needed in order for the code to fully run and needed for follow-on parts of Project 1.

Constructors

  • The constructor validates its inputs in the code. If someone passes an invalid suit or value the code will throw an error.
  • There is no default constructor. No there doesn’t need to be one for Card or Deck since there are already defined constructors.

Readability and Style

  • The comments and the variable names and method names make it easy to follow the logic without running the code.
  • The code followed the Google Java Style Guide in terms of naming, braces, and spacing

Comments

Post a Comment

Popular posts from this blog

CST 349 / 300 Week 2

Image
Part 1: Review and Reflect Learning Strategy The top three items I am good at are developing and revising a schedule, taking notes, and preparing an outline and writing the paper. I have always thrived using a calendar and planner to create a daily schedule for myself and blocking out a time to study. I have always made it a priority to take good notes both while I am reading and/or listening to a lecture. It is difficult for me to completely digest everything all at once which makes the notes very helpful when studying. I used to hate writing essays because I would never know how to start. After I learned how to create an outline, it came a lot more natural and writing essays were not as difficult because the framework of the essay was already created. The top three areas I feel I am weak in are outlining textbooks, essay examinations, and using correct punctuation and grammar. Outlining textbooks has never really helped me, I end up highlighting everything or nothing and it didn’t re...
Read more

CST 349 / 300 Week 4

  Part One: Set Your Educational Goals Educational Goals in CS Program I want to dedicate time to studying and completing coursework for CS courses. I want to learn better studying and test taking skills. I want to learn how to document while appropriately citing resources. I want to learn and retain knowledge from all of the CS courses. I want to earn an A in all of the CS courses. I want to graduate with a Computer Science degree. I want to learn how to network professionally. Part Two: Set Your Career Goals Career Goals I want to reassign from my current position into a Project Manager role. I want to completely manage from start to finish a project for the systems that I currently operate. I want to be able to envision future capabilities for my organization as potential projects. I want to increase my salary to its highest potential. Part Three: Take a wild guess of your percentile of the ETS Computer Science test After viewing the ETS page, the test descri...
Read more

CST 338 Week 3

Nettra The variable names are clear what each is used for. They are meaningful in that their names are clear what they are used for. No issues with imports or warnings. The formatting of the document is very clear. There is a comment block at the top of each java class . Some feedback could be to add comments on methods within the code. Otherwise this is well written and all unit tests pass . Kevin The variable names are clear what each is used for. They are meaningful in that their names are clear what they are used for. No issues with imports or warnings. The formatting of the document is very clear. There is a comment block at the top of each java class. Some feedback could be to add comments on methods within the code. Otherwise this is well written and all unit tests pass. Sean The variable names are clear what each is used for. They are meaningful in that their names are clear what they are used for. No issues with imports or warnings. The formatting of the document is ...
Read more